Add more logging to dotnet test tracing #47449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
There was a problem hiding this comment.
PR Overview
This PR enhances the tracing for dotnet test execution by adding more logging to help diagnose project property evaluations.
- Added new using directives to support additional logging.
- Inserted multiple Logger.LogTrace calls to capture the state of project properties before and after re-evaluation.
- Included conditional logging in cases where the target framework is invalid.
Reviewed Changes
| File | Description |
|---|---|
| src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs | Added detailed trace logging around target framework evaluation and module creation |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs:132
- The TODO comment indicates that the intended behavior when the project is considered invalid is not fully defined. Consider clarifying and implementing proper error handling or detailed documentation for this branch.
else
Youssef1313
force-pushed
the
dev/ygerges/more-logging-dotnet-test
branch
from
3e93a12 to
1f8b468
Compare
mariam-abdulla
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #45927